Allow bzl_library to depend on non-bzl_library targets
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, `filegroup`. `bzl_library` doesn't actually read anything from the `StarlarkLibraryInfo` provider, and requiring all deps to be other `bzl_library` targets is really painful for anyone loading .bzls from `@bazel_tools` or `@platforms` because those core modules/repos don't want a dependency on Skylib just for access to `bzl_library`. The medium-term plan will be to move `bzl_library` into `@bazel_tools`; but before then, this can serve as a stop-gap.
Wyverald
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
tetromino
requested changes
Apr 24, 2024
There was a problem hiding this comment.
As far as I can see, the test doesn't test the new change. How about this setup instead:
c.bzl loads symbol A from a.bzl and symbol B from b.bzl
a.bzl is in a_filegroup
b.bzl is wrapped in b_bzl_library
c.bzl is wrapped in c_bzl_library with a_filegroup and b_bzl_filegroup in deps
And the test is a rule which verifies that c_bzl_library's DefaultInfo and StarlarkLibaryInfo include a.bzl, b.bzl, and c.bzl as expected
doesn't |
It doesn't test the content of the providers. If you want, I can push a commit to this PR to make the test cover this. |
if you have time, that'd be great! otherwise, I can get to it later today. |
|
Done now. |
I was in the process of writing a slightly more universal variation on the same theme, using skylib's standard analysistest machinery; I pushed that since I think it provides a useful example for analysistest usage. |
tetromino
approved these changes
Apr 24, 2024
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Apr 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 #### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 #### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 <!--## MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ```--> #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Apr 25, 2024
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.5.0` -> `1.6.0` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 ##### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 ##### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swiftformat
that referenced
this pull request
Apr 25, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 ##### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 ##### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 25, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.5.0` -> `1.6.0` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 ##### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 ##### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to bazel-contrib/rules_bazel_integration_test
that referenced
this pull request
Apr 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.5.0` -> `1.6.0` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 #### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 #### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 <!--## MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ```--> #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 25, 2024
…1042) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib_gazelle_plugin | bazel_dep | minor | `1.5.0` -> `1.6.0` | | [bazel_skylib_gazelle_plugin](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib_gazelle_plugin)</summary> ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 ##### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 ##### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Wyverald
pushed a commit
to bazel-contrib/bazel_features
that referenced
this pull request
Apr 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.5.0` -> `1.6.1` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.1`](https://togithub.com/bazelbuild/bazel-skylib/compare/1.6.0...1.6.1) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.6.0...1.6.1) ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 #### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 #### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 <!--## MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ```--> #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/bazel_features). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rrbutani
pushed a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
May 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.5.0` -> `1.6.1` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.5.0` -> `1.6.1` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.6.1`](https://togithub.com/bazelbuild/bazel-skylib/compare/1.6.0...1.6.1) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.6.0...1.6.1) ### [`v1.6.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.6.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.5.0...1.6.0) Release 1.6.0 #### What's Changed - Add helper functions for module extensions as `modules` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#457 - Make `out` on `native_binary` optional by [@​tpudlik](https://togithub.com/tpudlik) in [bazelbuild/bazel-skylib#474 - Remove outdated rules_cc dependency [@​cpsauer](https://togithub.com/cpsauer) in [bazelbuild/bazel-skylib#476 - Add toolchains argument to unittests.make by [@​jylinv0](https://togithub.com/jylinv0) in [bazelbuild/bazel-skylib#483 - Allow `bzl_library` to depend on non-`bzl_library` targets by [@​Wyverald](https://togithub.com/Wyverald) in [bazelbuild/bazel-skylib#495 #### New Contributors - [@​jylinv0](https://togithub.com/jylinv0) made their first contribution in [bazelbuild/bazel-skylib#483 - [@​tpudlik](https://togithub.com/tpudlik) made their first contribution in [bazelbuild/bazel-skylib#474 **Full Changelog**: bazelbuild/bazel-skylib@1.5.0...1.6.0 <!--## MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.6.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.6.0", dev_dependency = True) ```--> #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "41449d7c7372d2e270e8504dfab09ee974325b0b40fdd98172c7fbe257b8bcc9" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-1.6.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "8700f9204f3b0a32851cdf56c63b8d8d4fcf93b96707c590d1de8d84cf07ee7d", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.6.0/bazel-skylib-gazelle-plugin-1.6.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.6.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably,
filegroup.bzl_librarydoesn't actually read anything from theStarlarkLibraryInfoprovider, and requiring all deps to be otherbzl_librarytargets is really painful for anyone loading .bzls from@bazel_toolsor@platformsbecause those core modules/repos don't want a dependency on Skylib just for access tobzl_library.The medium-term plan will be to move
bzl_libraryinto@bazel_tools; but before then, this can serve as a stop-gap.