Skip to content

Commit

Permalink
Fix //src/test/java/net/starlark/java/eval:ScriptTest on M1 Macs
Browse files Browse the repository at this point in the history
Fixes #17005

Closes #17017.

PiperOrigin-RevId: 495539579
Change-Id: Id4b368e847d0570d6b492280f76469398ec8d9a5
  • Loading branch information
fmeum authored and hvadehra committed Feb 14, 2023
1 parent e8ef002 commit d0c314e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 0 additions & 2 deletions .bazelci/postsubmit.yml
Expand Up @@ -262,8 +262,6 @@ tasks:
- "-//src/test/java/com/google/devtools/build/lib/rules/objc:ObjcRulesTests"
# https://github.com/bazelbuild/bazel/issues/16975
- "-//scripts/docs:rewriter_test"
# https://github.com/bazelbuild/bazel/issues/17005
- "-//src/test/java/net/starlark/java/eval:ScriptTest"
# https://github.com/bazelbuild/bazel/issues/17006
- "-//src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest"
# https://github.com/bazelbuild/bazel/issues/17007
Expand Down
2 changes: 0 additions & 2 deletions .bazelci/presubmit.yml
Expand Up @@ -255,8 +255,6 @@ tasks:
- "-//src/test/java/com/google/devtools/build/lib/rules/objc:ObjcRulesTests"
# https://github.com/bazelbuild/bazel/issues/16975
- "-//scripts/docs:rewriter_test"
# https://github.com/bazelbuild/bazel/issues/17005
- "-//src/test/java/net/starlark/java/eval:ScriptTest"
# https://github.com/bazelbuild/bazel/issues/17006
- "-//src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest"
# https://github.com/bazelbuild/bazel/issues/17007
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/net/starlark/java/eval/testdata/json.star
Expand Up @@ -44,7 +44,7 @@ assert_fails(lambda: json.encode(struct(x = [1, {"x": len}])),
"in struct field .x: at list index 1: in dict key \"x\": cannot encode builtin_function_or_method as JSON")

def f(deep):
for x in range(10000):
for x in range(100000):
deep = [deep]
json.encode(deep)
assert_fails(lambda: f(None), "nesting depth limit exceeded")
Expand Down Expand Up @@ -128,7 +128,7 @@ assert_fails(lambda: json.decode('{1:2}'), "got int for object key, want string"
assert_fails(lambda: json.decode('{"one": 1,'), "unexpected end of file")
assert_fails(lambda: json.decode('{"one": 1, }'), 'unexpected character "}"')
# FIXME assert_fails(lambda: json.decode('{"one": 1]'), 'in object, got "]", want ',' or \'}\'')
assert_fails(lambda: json.decode('[' * 10000), "nesting depth limit exceeded")
assert_fails(lambda: json.decode('[' * 100000), "nesting depth limit exceeded")
# Unescaped control codes (even tabs) are forbidden in strings.
assert_fails(lambda: json.decode('"\t"'), r"invalid character '\\x09' in string literal")
assert_fails(lambda: json.decode('"\\u123"'), r"incomplete \\uXXXX escape")
Expand Down

0 comments on commit d0c314e

Please sign in to comment.