Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Extract Bazel registry creation into a SkyFunction #22052

Closed
bazel-io opened this issue Apr 18, 2024 · 3 comments
Closed

[7.2.0] Extract Bazel registry creation into a SkyFunction #22052

bazel-io opened this issue Apr 18, 2024 · 3 comments
Milestone
7.2.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22040
@bazel-io bazel-io added this to the 7.2.0 release blockers milestone Apr 18, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/BazelRepositoryModule.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BUILD
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java
src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java
src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisMock.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelDepGraphFunctionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelLockFileFunctionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunctionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleFunctionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/DiscoveryTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunctionTest.java
src/test/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorTest.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/BazelRepositoryModule.java src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BUILD src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunction.java src/main/java/com/google/devtools/build/lib/skyframe/packages/BazelPackageLoader.java src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisMock.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelDepGraphFunctionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelLockFileFunctionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunctionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleFunctionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/DiscoveryTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileFunctionTest.java src/test/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorTest.java

cc: @bazelbuild/triage

cc: @fmeum, @Wyverald

@Wyverald Wyverald mentioned this issue Apr 25, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #22138 by @Wyverald

github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
@Wyverald @fmeum
[7.2.0] Extract Bazel registry creation into a SkyFunction (#22138)
29bb8f2 
This gets rid of an ad-hoc cache maintained in `RegistryFactoryImpl` and
prepares for making registries aware of hashes stored in the lockfile.

Work towards #20369

Fixes #22052.

Closes #22040.

PiperOrigin-RevId: 626307340
Change-Id: I34b428553f7169c72ed7dddd2fe3ea5e6dca2a97

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992