Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Extract Bazel registry creation into a SkyFunction #22138

Merged
merged 1 commit into from Apr 26, 2024
Merged

[7.2.0] Extract Bazel registry creation into a SkyFunction #22138

merged 1 commit into from Apr 26, 2024

Conversation

Wyverald
Copy link
Member

This gets rid of an ad-hoc cache maintained in RegistryFactoryImpl and prepares for making registries aware of hashes stored in the lockfile.

Work towards #20369

Fixes #22052.

Closes #22040.

PiperOrigin-RevId: 626307340
Change-Id: I34b428553f7169c72ed7dddd2fe3ea5e6dca2a97

@fmeum @Wyverald
Extract Bazel registry creation into a SkyFunction
d3659d7 
This gets rid of an ad-hoc cache maintained in `RegistryFactoryImpl` and prepares for making registries aware of hashes stored in the lockfile.

Work towards #20369

Closes #22040.

PiperOrigin-RevId: 626307340
Change-Id: I34b428553f7169c72ed7dddd2fe3ea5e6dca2a97
@Wyverald Wyverald requested a review from a team as a code owner April 25, 2024 22:48
@Wyverald Wyverald enabled auto-merge April 25, 2024 22:48
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability Issues for Configurability team team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Apr 25, 2024
@iancha1992 iancha1992 mentioned this pull request Apr 25, 2024
Closed
@Wyverald Wyverald added this pull request to the merge queue Apr 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Apr 26, 2024
@iancha1992 iancha1992 removed this pull request from the merge queue due to a manual request Apr 26, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into release-7.2.0 with commit 29bb8f2 Apr 26, 2024
35 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Apr 26, 2024
@Wyverald Wyverald deleted the wyv-720-regfn branch April 26, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iancha1992 iancha1992 iancha1992 approved these changes

Assignees
No one assigned
Labels
team-Configurability Issues for Configurability team team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wyverald @iancha1992 @fmeum