Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export .bzl files in @bazel_tools//tools/... #12258

Closed
wants to merge 1 commit into from
Closed

Export .bzl files in @bazel_tools//tools/... #12258

wants to merge 1 commit into from

Conversation

achew22
Copy link
Member

@achew22 achew22 commented Oct 13, 2020

With this change it is now possible to create a bzl_library entry that has a deps entry for all its inputs.

@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@aiuto aiuto requested a review from c-parsons October 15, 2020 03:24
@achew22
Copy link
Member Author

achew22 commented Oct 20, 2020

@c-parsons friendly ping

@achew22 achew22 mentioned this pull request Oct 20, 2020
Merged
@achew22
Copy link
Member Author

achew22 commented Oct 23, 2020

@c-parsons friendly ping on this

@jin
Copy link
Member

jin commented Oct 26, 2020

This seems to be blocking rules_go from working nicely with Stardoc according to bazelbuild/bazel-gazelle#760 (comment). @c-parsons, could you take a look please?

@jin
Copy link
Member

jin commented Oct 26, 2020

cc @alandonovan and @brandjon as the owners of Starlark docgen tooling

@achew22
Copy link
Member Author

achew22 commented Oct 26, 2020

As a note, I think that something like this needs to be done for every .bzl file in @bazel_tools and related repos since stardoc requires all files that were transitively loaded to be in the data dependency for parsing. Unfortunately I haven't been able to come up with a clever way to test this and ensure the transitive set of loads is visible with just this change because I'm blocked on a more general error in Stardoc

@achew22
Copy link
Member Author

achew22 commented Oct 27, 2020

Friendly ping

@alandonovan alandonovan assigned brandjon and unassigned alandonovan Oct 27, 2020
@achew22
Copy link
Member Author

achew22 commented Oct 28, 2020

Even friendlier ping

@jin
Copy link
Member

jin commented Oct 28, 2020

@brandjon could you take a look at this please?

@achew22
Export .bzl files in @bazel_tools//tools/build_defs/repo
74384cf 
With this change it is now possible to create a `bzl_library` entry that has a `deps` entry for all its inputs.
@achew22 achew22 changed the title Export .bzl files in @bazel_tools//tools/build_defs/repo Export .bzl files in @bazel_tools//tools/... Oct 28, 2020
@achew22 achew22 mentioned this pull request Oct 29, 2020
Merged
@achew22
Copy link
Member Author

achew22 commented Oct 29, 2020

Friendly ping

@bazel-io bazel-io closed this in fb309f3 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-parsons c-parsons Awaiting requested review from c-parsons

@brandjon brandjon Awaiting requested review from brandjon

Assignees

@brandjon brandjon

@c-parsons c-parsons

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@achew22 @jin @brandjon @alandonovan @c-parsons