git cherry-pick for 4.2.0: flag-gated config_setting visibility #13701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was rolled back in bazelbuild@36d228b because of depot breakages. This version adds incompatible flags to safely introduce enforcement. See bazelbuild#12932 and bazelbuild#12933 for flag settings. *** Original change description *** Roll back bazelbuild#12877. *** Fixes bazelbuild#12669. RELNOTES: enforce config_setting visibility. See bazelbuild#12932 for details. PiperOrigin-RevId: 354930807
|
Followup for #13558 (comment). Passes |
gregestren
requested review from
katre
and removed request for
jin,
aiuto and
floriographygoth
gregestren
changed the title
|
thanks a lot for the effort! |
katre
approved these changes
Jul 19, 2021
|
This was merged to release-4.2.0-patches (after a quick rebase). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick request for 4.2.0 (#13558).
Original commit: 79989f9
Important note, as shown below, this commit does not introduce incompatible changes. You have to flip new
--incompatibleflags to get the effect.Roll forward config_setting visibility enforcement behind a flag.
This was rolled back in 36d228b
because of depot breakages.
This version adds incompatible flags to safely introduce enforcement.
See #12932 and
#12933 for flag settings.
*** Original change description ***
Roll back #12877.
Fixes #12669.
RELNOTES: enforce config_setting visibility. See #12932 for details.
PiperOrigin-RevId: 354930807