Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out system headers on macOS. #14971

Closed
wants to merge 1 commit into from
Closed

Filter out system headers on macOS. #14971

wants to merge 1 commit into from

Conversation

phst
Copy link
Contributor

@phst phst commented Mar 5, 2022

Fixes #14969.

RELNOTES:
Bazel now no longer includes system headers on macOS in coverage reports (#14969).

@phst phst requested a review from lberki as a code owner March 5, 2022 13:20
@lberki lberki requested review from c-mita and removed request for lberki March 7, 2022 07:52
@gregestren gregestren added the team-Rules-CPP Issues for C++ rules label Mar 7, 2022
@c-mita c-mita added the coverage label Mar 8, 2022
@c-mita
Copy link
Member

c-mita commented Mar 8, 2022

LGTM

@c-mita
Copy link
Member

c-mita commented Mar 8, 2022

@keith Can I ask you to verify that this doesn't have any unintended consequences? I'm not familiar with the Mac ecosystem at all.

keith
keith approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep should be safe, technically Xcode doesn't have to be installed to /Applications, so this could miss a non-standard installation case, but that's unlikely.

@bazel-io bazel-io closed this in 71747cc Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@c-mita c-mita c-mita approved these changes

Assignees

@oquenchil oquenchil

Labels
coverage team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage on macOS doesn't filter out system headers
5 participants
@phst @c-mita @keith @gregestren @oquenchil