Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[credentialhelper] Add parser for flag syntax #15906

Closed
wants to merge 3 commits into from
Closed

[credentialhelper] Add parser for flag syntax #15906

wants to merge 3 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Jul 18, 2022

Progress on #15856

@Yannic Yannic marked this pull request as ready for review July 18, 2022 15:42
@Yannic Yannic requested a review from a team as a code owner July 18, 2022 15:42
@Yannic
Copy link
Contributor Author

Yannic commented Jul 18, 2022

PTAL

@Yannic
Copy link
Contributor Author

Yannic commented Jul 18, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 18, 2022
@ckolli5
Copy link

ckolli5 commented Jul 18, 2022

@bazel-io fork 5.3.0

@bazel-io bazel-io mentioned this pull request Jul 18, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 18, 2022
@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Jul 19, 2022
sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 20, 2022
@Yannic
[credentialhelper] Add parser for flag syntax
3e78bcf 
Progress on bazelbuild#15856

Closes bazelbuild#15906.

PiperOrigin-RevId: 462095541
Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
@sgowroji sgowroji mentioned this pull request Jul 20, 2022
Merged
@sgowroji
Copy link
Member

sgowroji commented Jul 20, 2022 •
edited

Hey @Yannic, we are trying to Cherry-pick these changes to release-5.3.0. But pre-submit checks are failing due to missing dependencies. So, could you please help us in cherry picking these changes to release-5.3.0?

@Yannic
Copy link
Contributor Author

Yannic commented Jul 20, 2022

@sgowroji this depends on CommandLinePathFactory. I think cherry-pick should work just fine once #15931 is merged into release-5.3.0.

@Yannic Yannic deleted the yannic-ch-flagparse branch July 20, 2022 12:17
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
@Yannic @aranguyen
[credentialhelper] Add parser for flag syntax
67e6e58 
Progress on bazelbuild#15856

Closes bazelbuild#15906.

PiperOrigin-RevId: 462095541
Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jul 20, 2022
@Yannic @aranguyen
[credentialhelper] Add parser for flag syntax
e94f18c 
Progress on bazelbuild#15856

Closes bazelbuild#15906.

PiperOrigin-RevId: 462095541
Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
@sgowroji
Copy link
Member

sgowroji commented Jul 21, 2022 •
edited

Hello @Yannic, Thank you for the reply. I see Cherry-pick is still failling Even after #15931 PR is merged in to release -5.3.0. I see some compile errors of libauthandtls-hjar.jar for the above attached cherry picks which are missing. Could you please have a look and guide the necessary.

sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 21, 2022
@Yannic
[credentialhelper] Add parser for flag syntax
80183ac 
Progress on bazelbuild#15856

Closes bazelbuild#15906.

PiperOrigin-RevId: 462095541
Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d
@sgowroji sgowroji mentioned this pull request Jul 21, 2022
Closed
Yannic added a commit to EngFlow/bazel that referenced this pull request Jul 21, 2022
@Yannic
Move newCredentialHelperProvider into GoogleAuthUtils
e42252c 
Follow-up on bazelbuild#15930 due to
bazelbuild#15906

Progress on bazelbuild#15856
@Yannic Yannic mentioned this pull request Jul 21, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Jul 22, 2022
@Yannic
Move newCredentialHelperProvider into GoogleAuthUtils
446b1a2 
Follow-up on #15930 due to
#15906

Progress on #15856

Closes #15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519
sgowroji added a commit that referenced this pull request Jul 22, 2022
@sgowroji @Yannic @ckolli5
[credentialhelper] Add parser for flag syntax (#15929)
05e758d 
* [credentialhelper] Add parser for flag syntax

Progress on #15856

Closes #15906.

PiperOrigin-RevId: 462095541
Change-Id: I4d31ad2ae185b63f0945119483ffafd3ba121d3d

* Updating implements for  Converter.Contextless<UnresolvedScopedCredentialHelper>

* changes on implements Converter<UnresolvedScopedCredentialHelper> {

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Co-authored-by: Chenchu K <ckolli@google.com>
Co-authored-by: “Gowroji <ysgowrojwrojwroji@google.comle.com>
sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 22, 2022
@Yannic
Move newCredentialHelperProvider into GoogleAuthUtils
5e7351b 
Follow-up on bazelbuild#15930 due to
bazelbuild#15906

Progress on bazelbuild#15856

Closes bazelbuild#15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519
@sgowroji sgowroji mentioned this pull request Jul 22, 2022
Closed
@ShreeM01 ShreeM01 mentioned this pull request Jul 25, 2022
Merged
ckolli5 added a commit that referenced this pull request Jul 25, 2022
@ShreeM01 @Yannic @ckolli5
Move newCredentialHelperProvider into GoogleAuthUtils (#15973)
508f185 
Follow-up on #15930 due to
#15906

Progress on #15856

Closes #15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Yannic @ckolli5 @sgowroji @tjgq @bazel-io