[remote/downloader] Add incompatible flag for sending a list of headers as qualifier #16312
Conversation
|
@tjgq PTAL Ideally, I'd like to flip this before Bazel 6.0.0 to limit who depends on the old behavior. Not sure how feasible that is though. |
ShreeM01
added
team-Remote-Exec
AIUI the 6.0.0 branch cut has been postponed to Oct 10 (#16159 (comment)), so we still have some time. I agree that we should flip it; the sooner the better, so that our nightly downstream pipeline can catch anything that breaks. |
src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
Outdated
Show resolved
Hide resolved
| @@ -586,6 +586,15 @@ public RemoteOutputsStrategyConverter() { | |||
| + "`all` to print always.") | |||
| public ExecutionMessagePrintMode remotePrintExecutionMessages; | |||
|
|
|||
| @Option( | |||
| name = "incompatible_remote_downloader_send_all_headers", | |||
There was a problem hiding this comment.
Are you planning for this flag to eventually also affect HttpDownloader? If so, I'm wondering whether we should put it in a different Options class (not sure which one, though...)
There was a problem hiding this comment.
No. This flag is specific to GrpcRemoteDownloader and the remote assets API for downloading.
…rs as qualifier Closes bazelbuild#16312. PiperOrigin-RevId: 477770765 Change-Id: I31a2eac5b93c184dee7580a058b9b9fb10ddd9ff
No description provided.