Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_remote_downloader_send_all_headers #16357

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Sep 29, 2022

Fixes #16356

RELNOTES[INC]: --incompatible_remote_downloader_send_all_headers is flipped to true. See #16356 for details.

Fixes bazelbuild#16356

RELNOTES[INC] --incompatible_remote_downloader_send_all_headers is flipped to true. See bazelbuild#16356 for details.
@Yannic Yannic requested a review from a team as a code owner September 29, 2022 22:10
@tjgq
Copy link
Contributor

tjgq commented Sep 29, 2022

LGTM, I'll wait for the incompatible changes nightly pipeline results to come back before importing (I don't expect to see any problems, but just in case).

@tjgq tjgq changed the title Flip --incompatible_remote_downloader_send_all_headers incompatible_remote_downloader_send_all_headers Sep 29, 2022
@Yannic
Copy link
Contributor Author

Yannic commented Sep 29, 2022

@tjgq tjgq changed the title incompatible_remote_downloader_send_all_headers Flip --incompatible_remote_downloader_send_all_headers Sep 29, 2022
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Sep 30, 2022
@tjgq
Copy link
Contributor

tjgq commented Sep 30, 2022

The Tensorflow failures seem unrelated. Let's import this.

@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 30, 2022
@copybara-service copybara-service bot closed this in 0653d5f Oct 3, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 4, 2022
aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
Fixes bazelbuild#16356

RELNOTES[INC]: --incompatible_remote_downloader_send_all_headers is flipped to true. See bazelbuild#16356 for details.

Closes bazelbuild#16357.

PiperOrigin-RevId: 478506192
Change-Id: Id7b6e67c53fd4ec4455240ccbd40980c439b9a72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_remote_downloader_send_all_headers
3 participants