Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Downstream CI test] Flip package_group incompatible flags #16465

Closed
wants to merge 1 commit into from
Closed

[Downstream CI test] Flip package_group incompatible flags #16465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
View file
Open in desktop
Expand Up @@ -452,7 +452,7 @@ public final class BuildLanguageOptions extends OptionsBase {

@Option(
name = "incompatible_package_group_has_public_syntax",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand All @@ -463,7 +463,7 @@ public final class BuildLanguageOptions extends OptionsBase {

@Option(
name = "incompatible_fix_package_group_reporoot_syntax",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down Expand Up @@ -803,9 +803,9 @@ public StarlarkSemantics toStarlarkSemantics() {
public static final String INCOMPATIBLE_DISALLOW_STRUCT_PROVIDER_SYNTAX =
"-incompatible_disallow_struct_provider_syntax";
public static final String INCOMPATIBLE_PACKAGE_GROUP_HAS_PUBLIC_SYNTAX =
"-incompatible_package_group_has_public_syntax";
"+incompatible_package_group_has_public_syntax";
public static final String INCOMPATIBLE_FIX_PACKAGE_GROUP_REPOROOT_SYNTAX =
"-incompatible_fix_package_group_reporoot_syntax";
"+incompatible_fix_package_group_reporoot_syntax";
public static final String INCOMPATIBLE_DO_NOT_SPLIT_LINKING_CMDLINE =
"+incompatible_do_not_split_linking_cmdline";
public static final String INCOMPATIBLE_JAVA_COMMON_PARAMETERS =
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/query2/common/CommonQueryOptions.java
View file
Open in desktop
Expand Up @@ -139,7 +139,7 @@ public String getLineTerminator() {

@Option(
name = "incompatible_package_group_includes_double_slash",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.QUERY,
effectTags = {OptionEffectTag.TERMINAL_OUTPUT},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down
5 changes: 0 additions & 5 deletions tools/allowlists/config_feature_flag/BUILD
View file
Open in desktop
Expand Up @@ -2,11 +2,6 @@
# Package groups for restricting access to config_feature_flag to specific
# packages, allowing for careful rollout as it is an experimental feature.

package_group(
name = "config_feature_flag",
packages = ["//..."],
)

filegroup(
name = "srcs",
srcs = glob(["**"]),
Expand Down
8 changes: 8 additions & 0 deletions tools/allowlists/config_feature_flag/BUILD.tools
View file
Open in desktop
@@ -0,0 +1,8 @@
# Description:
# Package groups for restricting access to config_feature_flag to specific
# packages, allowing for careful rollout as it is an experimental feature.

package_group(
name = "config_feature_flag",
packages = ["public"],
)
5 changes: 0 additions & 5 deletions tools/allowlists/function_transition_allowlist/BUILD
View file
Open in desktop
@@ -1,11 +1,6 @@
# Description:
# Package group restricting access to starlark-defined transitions, allowing for careful rollout as it is an experimental feature.

package_group(
name = "function_transition_allowlist",
packages = ["//..."],
)

filegroup(
name = "srcs",
srcs = glob(["**"]),
Expand Down
7 changes: 7 additions & 0 deletions tools/allowlists/function_transition_allowlist/BUILD.tools
View file
Open in desktop
@@ -0,0 +1,7 @@
# Description:
# Package group restricting access to starlark-defined transitions, allowing for careful rollout as it is an experimental feature.

package_group(
name = "function_transition_allowlist",
packages = ["public"],
)