Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --host_per_file_copt #16618

Closed
wants to merge 1 commit into from
Closed

Add --host_per_file_copt #16618

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Oct 31, 2022

Fixes #12406

@keith keith mentioned this pull request Oct 31, 2022
Closed
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 1, 2022
@lberki lberki removed their request for review November 2, 2022 07:51
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 3, 2022
@copybara-service copybara-service bot closed this in 88e5c91 Nov 7, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 7, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 7, 2022
UebelAndre pushed a commit to UebelAndre/bazel that referenced this pull request Nov 8, 2022
@keith @UebelAndre
Add --host_per_file_copt
34bc3ee 
Fixes bazelbuild#12406

Closes bazelbuild#16618.

PiperOrigin-RevId: 486616830
Change-Id: Icd9774b2d05d09288a34375e229b13e2a74cf3d7
@UebelAndre UebelAndre mentioned this pull request Nov 8, 2022
Merged
ShreeM01 added a commit that referenced this pull request Nov 9, 2022
@UebelAndre @keith @ShreeM01
Add --host_per_file_copt (#16695)
4919d4a 
Fixes #12406

Closes #16618.

PiperOrigin-RevId: 486616830
Change-Id: Icd9774b2d05d09288a34375e229b13e2a74cf3d7

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
@Wyverald Wyverald removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 1, 2022
apattidb pushed a commit to databricks/bazel that referenced this pull request Jun 9, 2023
@UebelAndre @keith
@ShreeM01 @AlessandroPatti
Add --host_per_file_copt (bazelbuild#16695)
c16350d 
Fixes bazelbuild#12406

Closes bazelbuild#16618.

PiperOrigin-RevId: 486616830
Change-Id: Icd9774b2d05d09288a34375e229b13e2a74cf3d7

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for setting per-file host copt (e.g. --host_per_file_copt)
6 participants
@keith @brentleyjones @oquenchil @Wyverald @bazel-io @sgowroji