Fix branch coverage #17226
Closed
Fix branch coverage #17226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Rules-Server
|
Whilst I'm not necessarily against this change, it doesn't really make the report more "accurate". If the number of branches doesn't match, then we can't really say that the first branch from both sides correspond to one another. I am curious as to how you're getting into the case with differing branches though; I know its possible with C++ templates but I am curious if other constructs can cause it. |
comius
added
awaiting-user-response
|
Closing, because no user response since Feb, and for one month after flagged with waiting for user response. Please reopen if you have a response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a branch coverage final report issue.
Currently, in the
mergeBranchesfunction we add only LHS if two branch coverages, which we want to merge, have different amount of branches. This causes an inaccurate final coverage report. This PR enables merging LHS and RHS.