EXPERIMENT - Use LLVM env vars in collect_cc_coverage #18903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a lot of the duplication across different coverage shell tests, which all want similar functions.
github-actions
bot
added
the
awaiting-review
c-mita
removed
the
awaiting-review
They are provided by the C++ rules and make it clearer what tool is what. Also changes the C++ LLVM coverage test to specify GCOV as llvm-cov, since that is the analogous tool and better represents how a LLVM based tool chain might be configured.
Pavank1992
added
coverage
awaiting-review
sgowroji
added
team-Rules-Server
sgowroji
added
awaiting-user-response
|
Closing, it looks stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.