Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bzlmod migration to mention enable_bzlmod #19574

Closed

Conversation

jlisee
Copy link
Contributor

@jlisee jlisee commented Sep 20, 2023

It the migration guide make sure to explicitly tell the user to update their .bazelrc with the --enable_bzlmod so that Bzlmod will be active. This resolves #19561

When following the migration guide make sure to explicitly tell the user to update their `.bazelrc` with the `--enable_bzlmod` so that Bzlmod will be active.
@google-cla
Copy link

google-cla bot commented Sep 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Sep 20, 2023
@keertk
Copy link
Member

keertk commented Sep 20, 2023

Hi @jlisee could you sign the CLA please?

@keertk keertk added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Sep 20, 2023
@keertk keertk requested review from Wyverald and meteorcloudy and removed request for gregestren, fweikert and philomathing September 20, 2023 18:20
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 21, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bzlmod /external/migration page does not mention --enable_bzlmod
4 participants