Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report the config id with the failing target during toolchain resolution #19588

Closed
wants to merge 2 commits into from
Closed

Report the config id with the failing target during toolchain resolution #19588

wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Sep 21, 2023

No description provided.

@katre katre changed the title [WIP] Report the config id with the failing target during toolchain resolution Report the config id with the failing target during toolchain resolution Sep 21, 2023
@katre katre marked this pull request as ready for review September 21, 2023 23:00
@katre katre requested a review from a team as a code owner September 21, 2023 23:00
@katre katre requested review from gregestren and sdtwigg and removed request for a team September 21, 2023 23:00
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability Issues for Configurability team labels Sep 21, 2023
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 22, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 26, 2023
@fmeum
Copy link
Collaborator

fmeum commented Sep 26, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 26, 2023
@katre katre deleted the report-useful-failures branch September 26, 2023 12:54
@katre
Copy link
Member Author

katre commented Sep 26, 2023

Why is this flagged for a cherrypick to the next release? It's a nice feature for debugging but it's not related to any actual issues that I am aware of.

@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 26, 2023
@bazel-io bazel-io mentioned this pull request Sep 26, 2023
Closed
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 26, 2023
@katre @iancha1992
Report the config id with the failing target during toolchain resolution
0ff9279 
Closes bazelbuild#19588.

PiperOrigin-RevId: 568404339
Change-Id: Iaad6883496c897b76dfabce783db12efe14ed958
@iancha1992 iancha1992 mentioned this pull request Sep 26, 2023
Closed
@iancha1992
Copy link
Member

iancha1992 commented Sep 26, 2023 •
edited

@katre @fmeum @gregestren @sdtwigg
As per @meteorcloudy, it looks like it'd be nice to include and cherry-pick this, while waiting for other PR's. I tried to cherry-pick this, but there was one conflict because the "src/main/java/com/google/devtools/build/lib/skyframe/toolchains/ToolchainException.java" is currently missing in the release-6.4.0 branch. Think it's because it was renamed from "src/main/java/com/google/devtools/build/lib/skyframe/ToolchainException.java" (currently in release-6.4.0) to "src/main/java/com/google/devtools/build/lib/skyframe/toolchains/ToolchainException.java" (currently in master). Please advise or create a PR. Thank you!

cc: @bazelbuild/triage @meteorcloudy

@fmeum
Copy link
Collaborator

fmeum commented Sep 26, 2023 •
edited

@katre I flagged this since I found it to be the only way to make sense of toolchain resolution failures on current_java_runtime style targets. It's not fixing a bug, but still very useful to have in 6.X.

If you generally gree with the cherry-pick, I can look into resolving the conflicts tomorrow.

@katre
Copy link
Member Author

katre commented Sep 26, 2023

Sounds good, I'll be happy to check a PR.

@fmeum
Copy link
Collaborator

fmeum commented Sep 27, 2023

I tried to cherry-pick this, but it depends on 2a923f1, which in turn doesn't deal with the host configuration. I will give up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren gregestren approved these changes

@sdtwigg sdtwigg Awaiting requested review from sdtwigg

Assignees
No one assigned
Labels
team-Configurability Issues for Configurability team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@katre @fmeum @iancha1992 @gregestren @bazel-io