Use case-insensitive comparison for Windows paths in runfiles.bash
#19602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
added
team-ExternalDeps
Wyverald
approved these changes
Sep 22, 2023
Wyverald
added
awaiting-PR-merge
|
Hmm, actually, the test failure may be relevant. Could you take a look? |
fmeum
force-pushed
the
normalize-windows-path
branch
3 times, most recently
from
9cf5a18
to
b172c8d
Compare
fmeum
changed the title
runfiles.bash
fmeum
force-pushed
the
normalize-windows-path
branch
4 times, most recently
from
b172c8d
to
84398f3
Compare
When matching the path of `rlocation`'s caller in the Bash runfiles library, use a case-insensitive comparison when running in MSYS2 as Bazel emits paths that can be capitalized differently. In particular, this fixes failures when the output base path contains uppercase letters.
fmeum
force-pushed
the
normalize-windows-path
branch
from
84398f3
to
fdd6517
Compare
|
The test failure was indeed relevant, I switched to a different approach. I failed to reproduce this in a test as I would need to modify the |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Pavank1992
added
awaiting-review
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 6.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 25, 2023
When matching paths or path segments in the Bash runfiles library, use a case-insensitive comparison when running in MSYS2 as Bazel emits paths that can be capitalized differently. In particular, this fixes failures when the output base path contains uppercase letters. Closes bazelbuild#19602. PiperOrigin-RevId: 568323218 Change-Id: Ic4655b82b1acbaa9ed50118913d713fba3d7f5de
Wyverald
pushed a commit
that referenced
this pull request
Sep 25, 2023
…s.bash` (#19626) When matching paths or path segments in the Bash runfiles library, use a case-insensitive comparison when running in MSYS2 as Bazel emits paths that can be capitalized differently. In particular, this fixes failures when the output base path contains uppercase letters. Closes #19602. Commit ea4ab7d PiperOrigin-RevId: 568323218 Change-Id: Ic4655b82b1acbaa9ed50118913d713fba3d7f5de Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching paths or path segments in the Bash runfiles library, use a case-insensitive comparison when running in MSYS2 as Bazel emits paths that can be capitalized differently. In particular, this fixes failures when the output base path contains uppercase letters.