Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Turbine 0.2 #19604

Closed
wants to merge 1 commit into from
Closed

Update to Turbine 0.2 #19604

wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Sep 22, 2023

Fixes #19360

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 22, 2023
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Sep 22, 2023
meteorcloudy
meteorcloudy approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will conflict with the internal java diff utils upgrade, so you'll have to update the MODULE.bazel.lock file for the one submitted later.

@cushon
Copy link
Contributor Author

cushon commented Sep 25, 2023

This change will conflict with the internal java diff utils upgrade, so you'll have to update the MODULE.bazel.lock file for the one submitted later.

Thanks--the diff utils update landed, and I rebased this and regenerated the MODULE.bazel.lock and maven_install.json updates

@meteorcloudy
Copy link
Member

Awesome! Congrats and thank you!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 25, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@hvadehra hvadehra Awaiting requested review from hvadehra

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation processor option with space breaks header compiler parsing
3 participants
@cushon @meteorcloudy @iancha1992