Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bazel's embedded JDK to 21. #19648

Closed

Conversation

zhengwei143
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 27, 2023
@iancha1992 iancha1992 added the team-Performance Issues for Performance teams label Sep 27, 2023
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 28, 2023
distdir_deps.bzl Outdated Show resolved Hide resolved
@zhengwei143
Copy link
Contributor Author

Downstream pipeline seems fine, no new errors between this PR (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3340) vs HEAD (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3334#018ad466-3db3-43a8-a052-3177d8279b0a)

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 29, 2023
@EdSchouten
Copy link
Contributor

@zhengwei143 With this change landed, is it also possible for us to start submitting code changes to Bazel that require JDK21? Or do we first need to wait one or more release cycles?

@zhengwei143
Copy link
Contributor Author

That won't be possible yet - at least until we've migrated ourselves internally. We're pushing for that currently though, and hope to be able to do so in the near future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants