Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intern BAZEL_CURRENT_REPOSITORY define for the main repo #20376

Closed
wants to merge 1 commit into from
Closed

Intern BAZEL_CURRENT_REPOSITORY define for the main repo #20376

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 30, 2023

No description provided.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 30, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 30, 2023

@comius Do you know whether local_defines on a cc_library are subject to any kind of interning? If not, would you say that this is a useful improvement?

@fmeum fmeum closed this Nov 30, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 30, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 30, 2023

Closing this in light of the discussion in #20371

@fmeum fmeum deleted the intern-bazel-current-repository branch November 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fmeum