Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.0] BAZEL_CURRENT_REPOSITORY double escaped when using param files #20412

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bazel-io
Copy link
Member

@bazel-io bazel-io commented Dec 1, 2023

RELNOTES[INC]: The BAZEL_CURRENT_REPOSITORY preprocessor variable, which holds the canonical name of the Bazel repository containing a cc_* target, is now only set during compilation if the target depends on the C/C++ runfiles library @bazel_tools//tools/cpp/runfiles via deps or implementation_deps.

Fixes #20371

Closes #20388.

Commit 454b550

PiperOrigin-RevId: 587070254
Change-Id: I774dc38b031199179df1c63e04000a2ecc15e010

RELNOTES[INC]: The `BAZEL_CURRENT_REPOSITORY` preprocessor variable, which holds the canonical name of the Bazel repository containing a `cc_*` target, is now only set during compilation if the target depends on the C/C++ runfiles library `@bazel_tools//tools/cpp/runfiles` via `deps` or `implementation_deps`.

Fixes bazelbuild#20371

Closes bazelbuild#20388.

PiperOrigin-RevId: 587070254
Change-Id: I774dc38b031199179df1c63e04000a2ecc15e010
@bazel-io bazel-io requested a review from a team as a code owner December 1, 2023 20:45
@bazel-io bazel-io added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 1, 2023
@iancha1992 iancha1992 enabled auto-merge (squash) December 1, 2023 20:46
@iancha1992 iancha1992 merged commit 1b214d2 into bazelbuild:release-7.0.0 Dec 4, 2023
26 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants