Store remote registry file hashes in the lockfile #21901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
f81f997
to
3e6d66a
Compare
fmeum
changed the title
fmeum
changed the title
github-actions
bot
added
team-ExternalDeps
|
Currently stacked on #21906, but otherwise ready for review. |
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
1edb957
to
d2215e9
Compare
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
d2215e9
to
de3b782
Compare
|
This is no longer stacked and ready for review again. |
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
de3b782
to
de3badb
Compare
Wyverald
reviewed
Apr 17, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/GsonTypeAdapterUtil.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
20369-remote-file-hash
branch
2 times, most recently
from
9b1f024
to
4644add
Compare
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
c447815
to
1d5da5c
Compare
fmeum
force-pushed
the
20369-remote-file-hash
branch
3 times, most recently
from
ae53f76
to
32e04db
Compare
fmeum
force-pushed
the
20369-remote-file-hash
branch
3 times, most recently
from
9767acc
to
189282d
Compare
fmeum
force-pushed
the
20369-remote-file-hash
branch
2 times, most recently
from
3e435a3
to
467a2a8
Compare
Wyverald
approved these changes
May 2, 2024
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelModuleResolutionFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Selection.java
Outdated
Show resolved
Hide resolved
Wyverald
added
awaiting-PR-merge
|
@fmeum can you please add the Javadoc comment for |
fmeum
force-pushed
the
20369-remote-file-hash
branch
from
02228ae
to
64dc812
Compare
Done! |
|
quick update -- running into some internal test failures during import; will probably submit today or tomorrow |
|
For future reference:
No need to make any changes -- this is just informational |
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
Wyverald
pushed a commit
that referenced
this pull request
May 8, 2024
`MODULE.bazel`, `bazel_registry.json` and `source.json` files obtained from remote registries are stored in the repository cache and their hashes are collected in the lockfile. This speeds up incremental module resolutions, such as after adding a new `bazel_dep`. Yanked versions are not stored in the lockfile. Their handling will be part of a follow-up PR. Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit Work towards #20369 Closes #21901. PiperOrigin-RevId: 631195852 Change-Id: I35c30af7f9c3626bdbcb04c85b8c2502eeaafd3e
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2024
`MODULE.bazel`, `bazel_registry.json` and `source.json` files obtained from remote registries are stored in the repository cache and their hashes are collected in the lockfile. This speeds up incremental module resolutions, such as after adding a new `bazel_dep`. Yanked versions are not stored in the lockfile. Their handling will be part of a follow-up PR. Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit Work towards #20369 Closes #21901. PiperOrigin-RevId: 631195852 Change-Id: I35c30af7f9c3626bdbcb04c85b8c2502eeaafd3e Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
`MODULE.bazel`, `bazel_registry.json` and `source.json` files obtained from remote registries are stored in the repository cache and their hashes are collected in the lockfile. This speeds up incremental module resolutions, such as after adding a new `bazel_dep`. Yanked versions are not stored in the lockfile. Their handling will be part of a follow-up PR. Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit Work towards bazelbuild#20369 Closes bazelbuild#21901. PiperOrigin-RevId: 631195852 Change-Id: I35c30af7f9c3626bdbcb04c85b8c2502eeaafd3e
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODULE.bazel,bazel_registry.jsonandsource.jsonfiles obtained from remote registries are stored in the repository cache and their hashes are collected in the lockfile. This speeds up incremental module resolutions, such as after adding a newbazel_dep.Yanked versions are not stored in the lockfile. Their handling will be part of a follow-up PR.
Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit
Work towards #20369