Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link stamping to cc_shared_library #22082

Closed

Conversation

jsharpe
Copy link

@jsharpe jsharpe commented Apr 22, 2024

Adds missing stamp argument to call to cc_common.link in cc_shared_library. Fixes #21724

Adds missing stamp argument to call to `cc_common.link` in
`cc_shared_library`. Fixes bazelbuild#21724
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 22, 2024
@jsharpe jsharpe marked this pull request as draft April 22, 2024 22:06
@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label Apr 22, 2024
@jsharpe jsharpe closed this May 3, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cc_shared_library does not compile and link linkstamp sources
2 participants