Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Handle file type changes with in-process symlink creation #22116

Merged
merged 1 commit into from Apr 29, 2024

Conversation

bazel-io
Copy link
Member

SymlinkTreeUpdater now correctly replaces symlinks with directories and vice versa in runfiles trees.

Fixes #20266

Closes #22087.

PiperOrigin-RevId: 628028591
Change-Id: Id94cea42f9cdfab001e56242a329b8d6d253ba29

Commit 4b18dbe

`SymlinkTreeUpdater` now correctly replaces symlinks with directories and vice versa in runfiles trees.

Fixes bazelbuild#20266

Closes bazelbuild#22087.

PiperOrigin-RevId: 628028591
Change-Id: Id94cea42f9cdfab001e56242a329b8d6d253ba29
@bazel-io bazel-io added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Apr 25, 2024
@bazel-io bazel-io requested a review from a team as a code owner April 25, 2024 11:16
@bazel-io bazel-io requested a review from tjgq April 25, 2024 11:16
@keertk
Copy link
Member

keertk commented Apr 29, 2024

Hey @tjgq could you approve if it's good to go for 7.2 please?

@iancha1992 iancha1992 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into bazelbuild:release-7.2.0 with commit 143c6bd Apr 29, 2024
33 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants