[7.2.0] Only check for shard status file if a test passed #22143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file. Speculatively fixes bazelbuild#22028 Closes bazelbuild#22098. PiperOrigin-RevId: 628355694 Change-Id: I370c7aba331f2a7a89cb9a9ff99d32b1694fd03a
bazel-io
added
team-OSS
|
Hey @tjgq could you approve if it's good to go for 7.2 please? |
|
gentle ping @tjgq |
tjgq
approved these changes
May 8, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file.
Speculatively fixes #22028
Closes #22098.
PiperOrigin-RevId: 628355694
Change-Id: I370c7aba331f2a7a89cb9a9ff99d32b1694fd03a
Commit 874a050