Fix potential NPE in ModuleFileFunction #22152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SkyframeLookupResult#get` can return `null` even if `env.valuesMissing()` is `false`.
|
@bazel-io fork 7.2.0 |
github-actions
bot
added
team-ExternalDeps
Wyverald
approved these changes
Apr 26, 2024
Wyverald
added
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 29, 2024
`SkyframeLookupResult#get` can return `null` even if `env.valuesMissing()` is `false`. Closes bazelbuild#22152. PiperOrigin-RevId: 629099024 Change-Id: I54e675ce7bdf012d966308fb60d99e9b04e2d75f
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
`SkyframeLookupResult#get` can return `null` even if `env.valuesMissing()` is `false`. Closes #22152. PiperOrigin-RevId: 629099024 Change-Id: I54e675ce7bdf012d966308fb60d99e9b04e2d75f Commit dacfd9c --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by: iancha1992 <heec@google.com>
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
`SkyframeLookupResult#get` can return `null` even if `env.valuesMissing()` is `false`. Closes bazelbuild#22152. PiperOrigin-RevId: 629099024 Change-Id: I54e675ce7bdf012d966308fb60d99e9b04e2d75f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkyframeLookupResult#getcan returnnulleven ifenv.valuesMissing()isfalse.