Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for remote_files for http_archive #22155

Closed
wants to merge 18 commits into from
Closed

Add support for remote_files for http_archive #22155

wants to merge 18 commits into from

Commits on Apr 30, 2024

  1. Add support for remote_files for http_archive 

    This issue adds support necessary to tackle
bazelbuild/bazel-central-registry#1566

Add two new attributes to http_archive: remote_file_urls and
remote_file_integrity.

The purpose of these two attributes is to allow files to effectively be
overlaid ontop of an http_archive. The goal of such functionality would
be useful for BCR since the BUILD & WORKSPACE files need no longer be
stored as patch files.

This means we could probably deprecate `build_file` since that could be
referenced as a file:// url in the remote_file_urls attribute.

Co-authored-by: Mark Williams <markrwilliams@google.com>
    @fzakaria @goomrw
    fzakaria and goomrw committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    938b903 View commit details
    Browse the repository at this point in the history

  2. Update the MODULE.bazel.lock for test_repos

    @fzakaria
    fzakaria committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    665f2ba View commit details
    Browse the repository at this point in the history

  3. Remove spawn_strategy on account of bazelbuild#20753

    @fzakaria
    fzakaria committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7eab852 View commit details
    Browse the repository at this point in the history

  4. Added validation and async for remote_file 

    * Added async download for remote_file for http-archive via block param
* Added validation to check that there is no relative paths present
    @fzakaria
    fzakaria committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2e90536 View commit details
    Browse the repository at this point in the history

  5. Updated lock files

    @fzakaria
    fzakaria committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a81db3c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. update MODULE.bazel.lock

    @fzakaria
    fzakaria committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4f150b9 View commit details
    Browse the repository at this point in the history

  2. Add back windows and macos python extension in MODULE.bazel.lock

    @fzakaria
    fzakaria committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8a0b673 View commit details
    Browse the repository at this point in the history

  3. Added more tests 

    * Added disallow relative path
* Added disallow absolute path
* Added test for missing integrity
    @fzakaria
    fzakaria committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d0d2970 View commit details
    Browse the repository at this point in the history

  4. Added test for bad integrity

    @fzakaria
    fzakaria committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1ebfbd1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Address feedback from fmeum 

    * Fixup comments
* Add test that verifies remote_files works with more than 1 segment
    @fzakaria
    fzakaria committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9f61f11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into overlay-pr

    @fzakaria
    fzakaria committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9b897bd View commit details
    Browse the repository at this point in the history

  3. Update lock files

    @fzakaria
    fzakaria committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cf42f89 View commit details
    Browse the repository at this point in the history

  4. Add shard count to build rule

    @fzakaria
    fzakaria committed May 3, 2024
    Configuration menu
    Copy the full SHA
    89e4878 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Fixup docstring for remote_file_* attributes

    @fzakaria
    fzakaria committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6e558c0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into overlay-pr

    @fzakaria
    fzakaria committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f330333 View commit details
    Browse the repository at this point in the history

  3. Update lock files

    @fzakaria
    fzakaria committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3cc59bb View commit details
    Browse the repository at this point in the history

  4. update MODULE.bazel.lock

    @fzakaria
    fzakaria committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c91faf7 View commit details
    Browse the repository at this point in the history

  5. Address feedback in PR for comments

    @fzakaria
    fzakaria committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e3ad0a9 View commit details
    Browse the repository at this point in the history