Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark bazel_tools extensions as reproducible #22335

Closed
wants to merge 1 commit into from
Closed

Mark bazel_tools extensions as reproducible #22335

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 12, 2024

Removes unnecessary lockfile entries.

@fmeum
Mark bazel_tools extensions as reproducible
f884278 
Removes unnecessary lockfile entries.
@fmeum fmeum requested a review from Wyverald May 12, 2024 21:55
@fmeum fmeum marked this pull request as ready for review May 12, 2024 21:55
@fmeum fmeum requested review from a team, ahumesky and ted-xie as code owners May 12, 2024 21:55
@github-actions github-actions bot added team-Android Issues for Android team team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels May 12, 2024
@fmeum fmeum removed request for a team, ted-xie and ahumesky May 12, 2024 21:56
@fmeum
Copy link
Collaborator Author

fmeum commented May 12, 2024

@bazel-io fork 7.2.0

@bazel-io bazel-io mentioned this pull request May 12, 2024
Closed
@iancha1992
Copy link
Member

@fmeum @Wyverald is this ready to merge?

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 13, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented May 13, 2024

@Wyverald Something we should keep in mind: When we update Bazel to build with 7.2.0, we might end up with extension repos missing from the lock file that we need to build the test or dist repo cache. Maybe we can use either bazel vendor or bazel mod show_extension as an alternative to scraping the lock file?

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 13, 2024
Wyverald pushed a commit that referenced this pull request May 13, 2024
@fmeum @Wyverald
Mark bazel_tools extensions as reproducible
110be9b 
Removes unnecessary lockfile entries.

Closes #22335.

PiperOrigin-RevId: 633311588
Change-Id: Ia0ccb2fd14b28123115109db9fa921380319451e
@Wyverald Wyverald mentioned this pull request May 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
@Wyverald @fmeum
[7.2.0] Mark bazel_tools extensions as reproducible (#22353)
129c23d 
Removes unnecessary lockfile entries.

Closes #22335.

PiperOrigin-RevId: 633311588
Change-Id: Ia0ccb2fd14b28123115109db9fa921380319451e

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer and removed team-Android Issues for Android team team-Rules-CPP Issues for C++ rules labels May 14, 2024
@fmeum fmeum deleted the reproducible branch May 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fmeum @iancha1992 @keith @Wyverald