[7.2.0] Cherry-pick sandboxing changes #22342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fmeum
commented
May 13, 2024
fmeum
commented
- Add more logging to exception (b9741ed)
- Sandboxing: Fix crash triggered by precondition (978c50b)
We are seeing reports of an exception triggered due to unknown entries being present in the sandbox base. Without actually knowing what those files/directories are it is hard to know the next steps, for example if more entries should be added to the allowlist SANDBOX_BASE_PERSISTENT_DIRS or if the precondition check should be removed altogether. This change adds more logging to get the names of the entries RELNOTES:none PiperOrigin-RevId: 621118864 Change-Id: Ie606f12a4148490d2c218ef5ba84605218e4f919
The precondition was being triggered when the sandbox was left in a bad state caused by an unfinished initialization of the linux-sandbox. This change detects when that happens and cleans up accordingly. RELNOTES:none PiperOrigin-RevId: 630056883 Change-Id: Iea2423f2894966e8b53e1cd94e148c7de527544d
fmeum
changed the title
github-actions
bot
added
awaiting-review
fmeum
referenced
this pull request
May 13, 2024
The precondition was being triggered when the sandbox was left in a bad state caused by an unfinished initialization of the linux-sandbox. This change detects when that happens and cleans up accordingly. RELNOTES:none PiperOrigin-RevId: 630056883 Change-Id: Iea2423f2894966e8b53e1cd94e148c7de527544d
oquenchil
approved these changes
May 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
bazelbuild:release-7.2.0
with commit May 13, 2024
ad2e4d7
33 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.