Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Incremental lockfile format #22351

Merged
merged 3 commits into from
May 13, 2024
Merged

[7.2.0] Incremental lockfile format #22351

merged 3 commits into from
May 13, 2024

Conversation

Wyverald
Copy link
Member

Original commits:

Wyverald and others added 3 commits May 13, 2024 14:25
The current ModuleExtensionUsage class was designed in the days before we allowed multiple `use_extension` calls for the same extension in the same module. This PR brings the class up to speed to better reflect the actual API.

This will also lay the groundwork for `bazel mod tidy` working with `include()`d segments.

Work towards #22063

Closes #22307.

PiperOrigin-RevId: 632377764
Change-Id: I282a68bc7962088ae4583418f73b2e60a0ec88f0
The old lockfile fields and all code related to it as well as the workarounds for local path inclusions are removed.

The distribution archive lockfile needs to be checked in temporarily as the main `MODULE.bazel.lock` file does not contain the hashes for the registry files.

Fixes #19621
Fixes #20369

RELNOTES: The format for MODULE.bazel.lock is now less likely to result in merge conflicts and is updated incrementally, with only new files downloaded from registries and existing ones taken from the repository cache (if configured).

Closes #22154.

PiperOrigin-RevId: 633233519
Change-Id: Ie2c3042e4141a36e472b2c25cbd67be4aad096a1
@Wyverald Wyverald requested a review from a team as a code owner May 13, 2024 18:38
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability Issues for Configurability team team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels May 13, 2024
@keertk keertk self-requested a review May 13, 2024 18:51
@keertk keertk enabled auto-merge May 13, 2024 18:51
@keertk keertk added this pull request to the merge queue May 13, 2024
Merged via the queue into release-7.2.0 with commit 298d3d6 May 13, 2024
35 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 13, 2024
@Wyverald Wyverald deleted the wyv-720-b9a0578 branch May 13, 2024 19:48
Wyverald added a commit that referenced this pull request May 13, 2024
This test was disabled on presubmit in #22351 but we forgot to make the corresponding change for postsubmit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability Issues for Configurability team team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants