Add OS-specific BAZELISK_HOME #474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@fweikert could you take a look? Thanks in advance :) |
|
@fweikert - could you please have a look on that change ? |
|
@katre can you maybe help here ? |
fweikert
reviewed
Feb 27, 2024
README.md
Outdated
| @@ -195,6 +198,8 @@ Configuration variables are evaluated with precedence order. The preferred value | |||
| * Variables defined in the workspace root `.bazeliskrc` | |||
| * Variables defined in the user home `.bazeliskrc` | |||
|
|
|||
| Additionally, the bazelisk home directory is also evaluated in precedence order. The preffered value is OS-specific e.g. `BAZELISK_HOME_LINUX`, then we fall back to `BAZELISK_HOME`. | |||
There was a problem hiding this comment.
thanks for catching it, fixed
fweikert
reviewed
Feb 27, 2024
README.md
Outdated
| @@ -195,6 +198,8 @@ Configuration variables are evaluated with precedence order. The preferred value | |||
| * Variables defined in the workspace root `.bazeliskrc` | |||
| * Variables defined in the user home `.bazeliskrc` | |||
|
|
|||
| Additionally, the bazelisk home directory is also evaluated in precedence order. The preffered value is OS-specific e.g. `BAZELISK_HOME_LINUX`, then we fall back to `BAZELISK_HOME`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BAZELISK_HOMEshould be set as absolute path, but all supported OSes use different folder structure. This might be a problem if we want to globally setBAZELISK_HOMEfor all developers.Therefore we want to propose a change to add support for OS-specific
BAZELISK_HOME, for exampleBAZELISK_HOME_WINDOWS.