Cover missing cases during module extension label normalization #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
|
CC @Wyverald |
|
Sorry, not familiar with this code base nor with Go. |
Wyverald
reviewed
Dec 19, 2023
| @@ -66,6 +66,9 @@ prox9 = use_extension( | |||
| prox9.use(label = "@name//:bar") | |||
| prox10 = use_extension("@dep//:extensions.bzl", "other_ext", dev_dependency = bool(1)) | |||
| prox10.use(dict = {"foo": "bar"}) | |||
| prox11 = use_extension("extension.bzl", "ext") | |||
| prox12 = use_extension(":extension.bzl", "ext") | |||
| prox13 = use_extension("//:extension.bzl", "ext") | |||
There was a problem hiding this comment.
what about use_extension("@repo_name//:extension.bzl", "ext")?
There was a problem hiding this comment.
I added more tests covering this case, is that what you had in mind?
|
This is running into the same kind of likely unrelated CI failures on Windows as my other PR. |
fmeum
force-pushed
the
fix-normalization
branch
from
998e942
to
f6aef5e
Compare
|
@vladmos Friendly ping |
1 similar comment
|
@vladmos Friendly ping |
fmeum
force-pushed
the
fix-normalization
branch
2 times, most recently
from
169aa8f
to
7e846e2
Compare
The previous logic missed to normalize cases such as "extension.bzl" and ":extension.bzl". Instead of enumerating cases, parse the label and track it in canonical form.
fmeum
force-pushed
the
fix-normalization
branch
from
7e846e2
to
9507332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic missed to normalize cases such as "extension.bzl" and ":extension.bzl". Instead of enumerating cases, parse the label and track it in canonical form.
Related to bazelbuild/bazel#20482