chore(bazel): add MODULE.bazel files for bzlmod #1245
Conversation
mmorel-35
force-pushed
the
bzlmod
branch
5 times, most recently
from
f7fca2c
to
c23ff51
Compare
mmorel-35
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
mmorel-35
force-pushed
the
bzlmod
branch
4 times, most recently
from
9d2ac99
to
ada6c6d
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
ping @vladmos |
|
Something to be aware of: The release versioning used by this repo is incompatible with how Go modules are versioned. It would be great if this could be resolved before this module is added to the BCR. This could otherwise result in quite a bit of pain for Go projects using the repo as a Go module and also picking it up as a transitive bazel_dep. |
| bazel_dep(name = "gazelle", version = "0.34.0", repo_name = "bazel_gazelle") | ||
| bazel_dep(name = "protobuf", version = "23.1", repo_name = "com_google_protobuf") | ||
| bazel_dep(name = "rules_go", version = "0.45.1", repo_name = "io_bazel_rules_go") | ||
| bazel_dep(name = "rules_nodejs", version = "5.8.2") |
There was a problem hiding this comment.
Could some of these deps be dev dependencies instead?
There was a problem hiding this comment.
Probably,
Any advice on how to identify which are ?
as one option to consider (and I wonder if we are doing it right), https://github.com/aspect-build/aspect-cli/tags publishes two tags for each release, one that looks like a bazel module version and one that looks like a Go package version (prefixed with |
|
@vladmos Would that be an option for buildtools? |
| @@ -4,3 +4,4 @@ | |||
| .ijwb | |||
| *.iml | |||
| /.bazelrc.user | |||
| MODULE.bazel.lock | |||
There was a problem hiding this comment.
What's this file? Is it being created by your editor?
There was a problem hiding this comment.
It's the lockfile Bazel creates for MODULE.bazel. It is currently hard to share across machines, which is why it's commonly added to .gitignore.
There was a problem hiding this comment.
bzlmod has a lockfile which afaiui the primary feature is it allows you to build offline. but it is pretty verbose, and i believe there are some cross-platform holes in it today, so it adds some maintenance burden to check in unless you really need it. ignoring it allows you the benefits locally w/o having to deal with updating it
Related to #1204
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com