buildozer: correctly substitute custom string attrs #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thumphries-stripe
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Comment on lines
+436
to
+441
| { | ||
| name: "custom_attr", | ||
| args: []string{"*", "^//(.*)$", "//foo/${1}"}, | ||
| buildFile: `cc_library(my_custom_attr = "//bar/baz:quux")`, | ||
| expected: `cc_library(my_custom_attr = "//foo/bar/baz:quux")`, | ||
| }, |
There was a problem hiding this comment.
This test case covers the bug in question, the others are included just for fun.
I confirmed the test fails if my change is reverted.
This was referenced Apr 17, 2024
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substitutebuildozer commandgetAttrValueExprruns via theTypeOfmap, and encodes the value as an ident if the type is not known. This works correctly for known attributes, but produces an invalid result for anything not contained in that map.However, we already know the attribute is a string due to the type assertion on L543, and can construct it directly.