buildozer: handle multiple glob tokens in set command #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stagnation
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
stagnation
changed the title
In the 'set' command, following the work from bazelbuild#100.
stagnation
force-pushed
the
feature/buildozer-handle-multiple-glob-tokens
branch
from
3c068ff
to
2707289
Compare
|
Just found this: #572 which also improves globs, higher up in the parser. Is that a better solution to revive and continue with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #1249. This continues the special case handling for globs in
set X glob(...)commands from #100. Ideally we should have a higher parsing level to extract the inner arguments from functions so they can be reorganized like regular files are. This does not work foradd X glob(...)which follows the status quo. At the moment we only usesetinternally but can look ataddtoo on the back burner. Thanks for this wonderful tool!