Do not declare bash output on windows #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling declare_file on windows even if later is overwritten is a problem in windows genereting the following error ``` The following files have no generating action: buildifier.bash ```
limdor
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
This was referenced Apr 7, 2024
Merged
Closed
limdor
commented
Apr 7, 2024
| @@ -168,8 +168,6 @@ def buildifier_impl_factory(ctx, test_rule = False): | |||
| fail("Cannot use 'no_sandbox' without a 'workspace'") | |||
| workspace = ctx.file.workspace.path | |||
|
|
|||
| out_file = ctx.actions.declare_file(ctx.label.name + ".bash") | |||
There was a problem hiding this comment.
Note for the reviewer, this is already present in https://github.com/bazelbuild/buildtools/pull/1262/files#diff-c5e2ba5db338e88cf7c850afd25c044dfa97198fefa4b296370c9286ab81d415L184
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
Calling declare_file on windows even if later is overwritten is a problem in windows genereting the following error ``` The following files have no generating action: buildifier.bash ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling declare_file on windows even if later is overwritten is a problem in windows genereting the following error