Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Locating runfiles with Bzlmod" #269

Merged
merged 10 commits into from Aug 17, 2022
Merged

Add "Locating runfiles with Bzlmod" #269

merged 10 commits into from Aug 17, 2022

Commits on Aug 17, 2022

  1. Add "Locating runfiles with Bzlmod"

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    27707aa View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    d33bd4a View commit details
    Browse the repository at this point in the history

  3. Address comment on workspace name

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    87374d1 View commit details
    Browse the repository at this point in the history

  4. Clarify that the main repo's canonical name does not start with @

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    24144cd View commit details
    Browse the repository at this point in the history

  5. Determine the repo context in Rlocation, not Create

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5d0d963 View commit details
    Browse the repository at this point in the history

  6. Address @oquenchil's comments

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1924d3b View commit details
    Browse the repository at this point in the history

  7. Clarify why RunfilesLibraryUsersProvider is needed

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    d72d749 View commit details
    Browse the repository at this point in the history

  8. Add a further special case and fix the example

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0952711 View commit details
    Browse the repository at this point in the history

  9. Propose to reuse RunfilesProvider

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    e645fec View commit details
    Browse the repository at this point in the history

  10. Mark as approved

    @fmeum
    fmeum committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    ae3f1fc View commit details
    Browse the repository at this point in the history