Add basic bzlmod example #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a way to setup the androidsdk repo in a bzlmod compatible way.
|
The first commit is #147, second one duplicates basicapp and makes it bzlmod compatible |
keith
commented
Sep 20, 2023
|
|
||
| # Disabled to avoid //external:android deps in bazel itself | ||
| common --android_sdk=@androidsdk//:sdk | ||
| common --optimizing_dexer=//:optimizing_dexer |
There was a problem hiding this comment.
this is a workaround to avoid having this target in bazel reference //external:android
|
Using this bazel bazelbuild/bazel#19575 you can almost get a working build of the sample app added here, in general this gives an idea of what needs to be fixed |
keith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.