Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android_external in anticipation of dependency in @bazel_tools #211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jylinv0
Copy link

@jylinv0 jylinv0 commented Mar 1, 2024

To remove all //external:android usages in @bazel_tools, all routing to @androidsdk will go through the new module @android_external. We have to add it to @rules_android before we can migrate @bazel_tools.

For backward compatibility, we can't remove all 'bind' calls until @bazel_tools is //external-free. Move bind calls to WORKSPACE.bzlmod because we can't have them stay in module extension implementation. It means the bind call happens before we have @androidsdk defined, so we add alias at top level to forward the binding to @androidsdk. However, @rules_android~~android_sdk_repository_extension~androidsdk is not visible from //external:<blash> when the root module is not @rules_android. So the example/basicapp still make direct android_sdk_repository call so its bind calls are in order.

@jylinv0 jylinv0 force-pushed the sdk_repository_ext branch 2 times, most recently from 4754221 to 044c963 Compare March 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant