tests: move test_chdir out of legacy #3680
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/make-chdir-core
branch
from
f3c8244
to
079f017
Compare
With recent events in 1.21, we found that this test suite is quite relevant to rules_go's test setup. In particular, we do care about the Working Directory of the test at runtime. Mark it as core to help ensure the longevity of the behavior.
fmeum
force-pushed
the
sluongng/make-chdir-core
branch
from
654cab4
to
37d6ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent events in 1.21, we found that this test suite is quite
relevant to rules_go's test setup. In particular, we do care about the
Working Directory of the test at runtime.
Mark it as core to help ensure the longevity of the behavior.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review