Migrate github.com/golang/mock to github.com/uber-go/mock #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
manjari25
force-pushed
the
manjari25/UberMock
branch
from
612645f
to
c1654ab
Compare
manjari25
force-pushed
the
manjari25/UberMock
branch
from
c1654ab
to
3981dc9
Compare
linzhp
reviewed
Sep 25, 2023
| @@ -1,6 +1,6 @@ | |||
| """ | |||
| [gazelle rule]: https://github.com/bazelbuild/bazel-gazelle#bazel-rule | |||
| [golang/mock]: https://github.com/golang/mock | |||
| [uber-go/mock]: https://github.com/uber-go/mock | |||
There was a problem hiding this comment.
The package name is go.uber.org/mock. Maybe we should refer to that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
rules_goprovides a bazel rule; gomock.bzl to use github.com/golang/mock, a mocking framework in Golang.Starting June 2023, github.com/golang/mock is no longer maintained. The repo forked from this at github.com/uber-go/mock is actively maintained.
This PR migrates
rules_goto use the forked repo for gomock bazel rule instead of the unmaintained repo.Which issues(s) does this PR fix?
Fixes #3709