upgrade tools #3730
Merged
upgrade tools #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sluongng I've decided to push this forward, it seems that it needs to have an upload to mirror? |
hawkingrei
force-pushed
the
try_to_upgrade_tools
branch
2 times, most recently
from
4464e94
to
dff3939
Compare
hawkingrei
commented
Oct 29, 2023
hawkingrei
force-pushed
the
try_to_upgrade_tools
branch
from
3172c24
to
0f81c57
Compare
hawkingrei
commented
Oct 30, 2023
|
@sluongng CI has passed. |
|
@fmeum PTAL |
sluongng
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM
Curious readers might want to give https://github.com/golang/tools/releases a read for latest features. A lot of them are gopls related, which are irrelevant to rules_go, but the analysis and memory improvements are interesting regardless.
|
Thanks for taking this on! Looks good to me. @tyler-french Could you give this a test run? |
There was a problem hiding this comment.
Thanks for taking this on! Looks good to me.
@tyler-french Could you give this a test run?
@fmeum working on testing this now.
@hawkingrei Could you git rebase -i and squash this PR into one commit? This might make it a bit easier to test.
Also added a couple of comments.
hawkingrei
force-pushed
the
try_to_upgrade_tools
branch
3 times, most recently
from
21b88be
to
1dcec52
Compare
I have rebased it. |
hawkingrei
force-pushed
the
try_to_upgrade_tools
branch
from
1dcec52
to
a3ec8cf
Compare
tyler-french
approved these changes
Nov 1, 2023
upgrade x/tools v0.14.0 upgrade x/sys v0.13.0 Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
fmeum
force-pushed
the
try_to_upgrade_tools
branch
from
a3ec8cf
to
d9ed41f
Compare
|
@hawkingrei Thanks! |
When will we release a new rules_go on the github release ? |
|
@tyler-french is already working on it |
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Nov 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3715 - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3716 - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3718 - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3720 - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3724 - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3722 - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [bazelbuild/rules_go#3734 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3740 - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [bazelbuild/rules_go#3730 - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3725 - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [bazelbuild/rules_go#3744 - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3747 - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [bazelbuild/rules_go#3748 - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3743 - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [bazelbuild/rules_go#3688 - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3750 - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3751 - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [bazelbuild/rules_go#3672 - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3745 #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [bazelbuild/rules_go#3718 - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [bazelbuild/rules_go#3734 - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/rules_go#3740 - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [bazelbuild/rules_go#3688 - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/rules_go#3672 **Full Changelog**: bazelbuild/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Nov 20, 2023
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3715 - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3716 - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3718 - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3720 - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3724 - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3722 - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [bazelbuild/rules_go#3734 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3740 - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [bazelbuild/rules_go#3730 - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3725 - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [bazelbuild/rules_go#3744 - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3747 - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [bazelbuild/rules_go#3748 - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3743 - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [bazelbuild/rules_go#3688 - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3750 - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3751 - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [bazelbuild/rules_go#3672 - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3745 #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [bazelbuild/rules_go#3718 - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [bazelbuild/rules_go#3734 - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/rules_go#3740 - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [bazelbuild/rules_go#3688 - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/rules_go#3672 **Full Changelog**: bazelbuild/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Nov 22, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3715 - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3716 - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3718 - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3720 - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [bazelbuild/rules_go#3724 - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3722 - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [bazelbuild/rules_go#3734 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3740 - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [bazelbuild/rules_go#3730 - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3725 - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [bazelbuild/rules_go#3744 - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3747 - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [bazelbuild/rules_go#3748 - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3743 - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [bazelbuild/rules_go#3688 - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3750 - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3751 - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [bazelbuild/rules_go#3672 - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3745 #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [bazelbuild/rules_go#3718 - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [bazelbuild/rules_go#3734 - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/rules_go#3740 - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [bazelbuild/rules_go#3688 - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/rules_go#3672 **Full Changelog**: bazelbuild/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
x/toolsis too old to upgrade the linter such as golangci-linter.Which issues(s) does this PR fix?
Fixes #3640
Other notes for review