cgo2: refactor for readability #3771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a no-op refactoring of cgo2 func: - Rename from cgo2 to cgo - Reorganize function's arguments into a cgoOption struct - Replace usages of deprecated ioutil with `io` and `os` equivalents No functionality change is expected.
|
We could also rename the file from cgo2.go -> cgo.go, but I was afraid of the noisy diff during code review so I decided against it. |
|
This came out of my reading of #3770 to help aid my understanding of the current code. Zooming out a bit, we already have some of the basic structs such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op refactoring of cgo2 func:
ioandosequivalentsNo functionality change is expected.