fix(gpd): don't panic on invalid root #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-french
force-pushed
the
jamy/nil-pkg-root
branch
from
f6584f5
to
56e63e8
Compare
|
I think this a very simple and safe change that is safe merging as is (cc @fmeum). Adding a test would be good, but I don't think this bug fix should necessarily need one, as it seems pretty trivial to avoid panicking. |
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Dec 19, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [bazelbuild/rules_go#3749 #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@​io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [bazelbuild/rules_go#3782 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3757 - update documentation for 0.43.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3758 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3760 - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3762 - Do not choose prereleases as highest versions by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3764 - Remove unmaintained validators by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3768 - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3775 - feat(packagesdriver): add \_test suffix to pkgPath by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3777 - Typo --test_runner_fail_fast by [@​Clement-Jean](https://togithub.com/Clement-Jean) in [bazelbuild/rules_go#3773 - Panic when a test times out by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3749 - Fix integration tests with Bazel@HEAD by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3781 - Automatically register SDKs for common execution platforms by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3634 - fix `aux_files` relative paths for gomock source mocks (fix [#​3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@​ikavalio](https://togithub.com/ikavalio) in [bazelbuild/rules_go#3753 - Update to modern protoc plugins by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3761 - Add integration tests for protoc-gen-go-grpc by [@​ryanpbrewster](https://togithub.com/ryanpbrewster) in [bazelbuild/rules_go#3787 - Add Bzlmod support for `nogo` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3782 - fix(gpd): don't panic on invalid root by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3779 - Pass env to gentestmain so it will correctly filter by [@​patrickmscott](https://togithub.com/patrickmscott) in [bazelbuild/rules_go#3785 - prepare release 0.44.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3788 #### New Contributors - [@​Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [bazelbuild/rules_go#3773 - [@​ikavalio](https://togithub.com/ikavalio) made their first contribution in [bazelbuild/rules_go#3753 - [@​ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [bazelbuild/rules_go#3787 **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Dec 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [bazelbuild/rules_go#3749 #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@​io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [bazelbuild/rules_go#3782 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3757 - update documentation for 0.43.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3758 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3760 - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3762 - Do not choose prereleases as highest versions by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3764 - Remove unmaintained validators by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3768 - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3775 - feat(packagesdriver): add \_test suffix to pkgPath by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3777 - Typo --test_runner_fail_fast by [@​Clement-Jean](https://togithub.com/Clement-Jean) in [bazelbuild/rules_go#3773 - Panic when a test times out by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3749 - Fix integration tests with Bazel@HEAD by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3781 - Automatically register SDKs for common execution platforms by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3634 - fix `aux_files` relative paths for gomock source mocks (fix [#​3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@​ikavalio](https://togithub.com/ikavalio) in [bazelbuild/rules_go#3753 - Update to modern protoc plugins by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3761 - Add integration tests for protoc-gen-go-grpc by [@​ryanpbrewster](https://togithub.com/ryanpbrewster) in [bazelbuild/rules_go#3787 - Add Bzlmod support for `nogo` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3782 - fix(gpd): don't panic on invalid root by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3779 - Pass env to gentestmain so it will correctly filter by [@​patrickmscott](https://togithub.com/patrickmscott) in [bazelbuild/rules_go#3785 - prepare release 0.44.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3788 #### New Contributors - [@​Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [bazelbuild/rules_go#3773 - [@​ikavalio](https://togithub.com/ikavalio) made their first contribution in [bazelbuild/rules_go#3753 - [@​ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [bazelbuild/rules_go#3787 **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Dec 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [bazelbuild/rules_go#3749 #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@​io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [bazelbuild/rules_go#3782 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3757 - update documentation for 0.43.0 release by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3758 - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3760 - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/rules_go#3762 - Do not choose prereleases as highest versions by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3764 - Remove unmaintained validators by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3768 - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3775 - feat(packagesdriver): add \_test suffix to pkgPath by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3777 - Typo --test_runner_fail_fast by [@​Clement-Jean](https://togithub.com/Clement-Jean) in [bazelbuild/rules_go#3773 - Panic when a test times out by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3749 - Fix integration tests with Bazel@HEAD by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3781 - Automatically register SDKs for common execution platforms by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3634 - fix `aux_files` relative paths for gomock source mocks (fix [#​3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@​ikavalio](https://togithub.com/ikavalio) in [bazelbuild/rules_go#3753 - Update to modern protoc plugins by [@​mering](https://togithub.com/mering) in [bazelbuild/rules_go#3761 - Add integration tests for protoc-gen-go-grpc by [@​ryanpbrewster](https://togithub.com/ryanpbrewster) in [bazelbuild/rules_go#3787 - Add Bzlmod support for `nogo` by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3782 - fix(gpd): don't panic on invalid root by [@​JamyDev](https://togithub.com/JamyDev) in [bazelbuild/rules_go#3779 - Pass env to gentestmain so it will correctly filter by [@​patrickmscott](https://togithub.com/patrickmscott) in [bazelbuild/rules_go#3785 - prepare release 0.44.0 by [@​tyler-french](https://togithub.com/tyler-french) in [bazelbuild/rules_go#3788 #### New Contributors - [@​Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [bazelbuild/rules_go#3773 - [@​ikavalio](https://togithub.com/ikavalio) made their first contribution in [bazelbuild/rules_go#3753 - [@​ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [bazelbuild/rules_go#3787 **Full Changelog**: bazelbuild/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
In rare cases the root won't actually have a package in the registry, causing the lookup to panic, and subsequently cause gopls (or other tools) to fail their resolution, and likely try multiple times.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Will add a test case shortly, hence the draft