Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving logging for subcommand failure #3824

Merged
merged 2 commits into from Jan 9, 2024
Merged

improving logging for subcommand failure #3824

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01bf23
improving logging for subcommand failure
linzhp Jan 9, 2024
003879e
Merge branch 'master' into log
linzhp Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/tools/builders/env.go
View file
Open in desktop
Expand Up @@ -168,7 +168,7 @@ func runAndLogCommand(cmd *exec.Cmd, verbose bool) error {
cleanup := passLongArgsInResponseFiles(cmd)
defer cleanup()
if err := cmd.Run(); err != nil {
return fmt.Errorf("error running subcommand %s: %v", cmd.Path, err)
return fmt.Errorf("error running subcommand %s: %w", formatCommand(cmd), err)
}
return nil
}
Expand Down