Fix invalid reference in coursier.bzl #1119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenmj
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
shs96c
reviewed
Apr 29, 2024
| @@ -1364,7 +1364,7 @@ pinned_coursier_fetch = repository_rule( | |||
| doc = "Instructions to re-pin the repository if required. Many people have wrapper scripts for keeping dependencies up to date, and would like to point users to that instead of the default.", | |||
| ), | |||
| "excluded_artifacts": attr.string_list(default = []), # only used for hash generation | |||
| "_workspace_label": attr.label(default = Label("@//does/not:exist")), | |||
| "_workspace_label": attr.label(default = Label("@@//does/not:exist")), | |||
There was a problem hiding this comment.
We still need to support Bazel 5 and 6, so this will cause a regression there. I think we need to do something smart to figure out whether or not bzlmod is being used (not just checking the version number), and then Do The Right Thing
There was a problem hiding this comment.
The maven_bom.bzl file has a utility method to determine whether we're using bzlmod or not. We might want to lift that out into another file and depend on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coursier.bzl contains a reference which is not compatible with bzlmod. Fixes #1118.