Fix coursier credentials #700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
lgzy
force-pushed
the
fix-repository-credentials
branch
from
fdd6da4
to
79a2a91
Compare
shs96c
reviewed
Jul 5, 2022
|
Sorry for the slow response to your initial PR --- I missed this in my reviews, and only just saw it. I appreciate your patience! |
lgzy
force-pushed
the
fix-repository-credentials
branch
from
5d850d6
to
7190473
Compare
lgzy
force-pushed
the
fix-repository-credentials
branch
from
7190473
to
fa1b0c8
Compare
|
fixed the offending test. The current failures don't seem to be relevant? |
|
@lgzy can you rebase this PR on latest master? |
|
I believe this was fixed with #721 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
_repository_credentialsto return a string surrounded with quotes as the result is passed to commandline as one of parameters in the form of... --credentials <result string>and ends up being incorrectly parsed. The quotes enable it to be correctly parsed.