chore: upgrade to rules_js #749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is lazy and won't fetch any packages from npm when the loading phase visits scripts/BUILD
|
Failing because rules_js requires Bazel 5. @jin do you have a policy for when r_jvm_e will drop support for Bazel 4? |
|
We don't have concrete plans to drop backwards compat yet. Is this a necessary change? |
|
We only include the JS rules so we can run Also, I'd prefer to hold on until Bazel 6 for an upgrade to |
|
Not necessary at all, I was just driving by. Thanks! |
|
It's appreciated :) I'm looking forward to picking up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is lazy and won't fetch any packages from npm when the loading phase visits scripts/BUILD