Make the implementation of maven_publish "not private"
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a particular reason that the entire impl needs to be exported? Can we keep it locked down and improve the attributes? Just for API simplicity reasons. |
|
In this particular case, I want to add an extra provider to the output of the rule (for a ruleset that isn't public). In theory, I could add a new target, but that would break existing workflows, where people are already using the |
|
When I hear "extra provider", I think of aspects. Would that work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not officially part of our public API, but sophisticated users who are attempting to extend
maven_publishwill find this helpful