Add GitHub Action to build Java deploy jars #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
force-pushed
the
prebuilts-deploy
branch
23 times, most recently
from
19bd785
to
610f41e
Compare
jin
force-pushed
the
prebuilts-deploy
branch
5 times, most recently
from
4fd6492
to
6881aad
Compare
cheister
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we build the deploy jars under
//private/tools/java/...by hand. This PR adds a new GitHub action to build and upload those JARs if the PR contains a change that's transitively depended upon by any of the JARs.The implementation still requires us to download the zip and upload it in a new PR, but at least it's built from CI, not a local dev machine. Small improvement, that.
A possible next step is to change the upload artifact job into a create PR job, so whenever code changes for the java tools, we get an automated PR that updates the deploy jars in the repo.
Example run: https://github.com/jin/rules_jvm_external/actions/runs/6642435323